Primary tabs

Comments by User

Tuesday, December 29, 2020 - 16:31

And before I start creating merge conflicts, how are you doing cleaning up/ fixing credits?
Something I notice to be added there/ fixed:

- in CREDITS.csv the note: "unclear who made the hurt animation can be removed for the helmets" (I did it and I am already in the authors list somehow)
- https://opengameart.org/content/cyclops-and-his-eye is missing from credits and submissions
- https://opengameart.org/content/lpc-skirt-for-women is missing from credits and submissions

In the generator I still need to (at least):

- fix the shadows credits
- live credits list

Tuesday, December 29, 2020 - 16:19

I added the tooltip functionality, hard than I thought because splitting a CSV turned out more complicated than I expected. Anyways, have a look and let me know what you think!

With regard to the live updating list, that I can do as well.
If I understand correctly, you would like to ouput the selected sheet graphics credit's to the HTML. Actually like what you get as well when you press the button "Credits for this sheet", but then straight to the screen on update. Correct?

Tuesday, December 29, 2020 - 04:10

Cool!

No I will do that as well, I will update here once it is done. Let me know if you think of any other wishes.

I'll add my name as well to the helmets, why not:P And I saw I added the cyclope eye after you forked, so that missess attribution, the same goes for the female robe. Will add that as well.

Monday, December 28, 2020 - 15:28

I pushed some new changes:

- Removed the old credits handling
- Removed the ability to recolor assets (I think it is quite useless and it removes a bit of the messy code now that it is gone
- Updated the HTML with some improved instructions and formatting
- Added two buttons for credits: One to generate the csv for all assets, and one for only the selected assets of the current resulting spritesheet.

Codewise, it again doesn't deserve the price for beauty but it works, and I think this more or less covers what we wrote down here. But I am eager to know: what do you think of it now?

Monday, December 28, 2020 - 13:52

Nice!

LGTM, I will merge it and start working on parsing it etc from JS.
Then we can see the result and if we still miss something urgent!

Funny note: I saw your comments on the dead animation for the horned helmets: "unclear who made the hurt animation". Well.. I did! Hahaha I think the only addition I made to the LPC set, by copy pasting some frames... Doesn't look to bad right? :P

Those other changes are very welcome also, we can continue that discussion in private also!

Sunday, December 27, 2020 - 16:14

axe2 and axe.png are both from darkwallke (https://opengameart.org/content/lpc-axe). You can see the axe2.png in the preview image he uploaded later.

The wolves are covered soon, so only remain the bandana:

That is a grayscale representation of head/bandanas/male/red.png. Did you find the attribution for that file? I think it is Sharm's, but I can be wrong.

And the lulhat_0: This on is not referenced in the HTML I see. It also has a flawed resolution. I can remove that one from the repo.

What do you think?

Sunday, December 27, 2020 - 15:30

Yes I just reached out to him, he confirmed that his adaptations permit the same licenses. He will confirm it here in this thread as well asap. So that is covered:) Any other items you need help with?

Good idea to put it there in order not to loose the link to that thread again!

Yes the wolves will be posted obviously, but Bencreating will do the honours ofc. I will ask him when he plans to do it. Let me know if there is something I can help with!

Sunday, December 27, 2020 - 08:07

Alright, good to hear that we are on the same page then:)

Let me worry about the code, you already did so much (unless you like to do some of the coding?). I can fix a tooltip.

So to the generator should be added:

- Selected assets to CSV
- All assets to CSV
- Tooltip
- "or a text description" what do you mean with that part?

I think it will be a great result, thanks again for initiating this!!

The DRM might be hard to track down btw, I remember there is a forum where for example Sharm and Redshrike wove it for their LPC submissions, but I can't find anymore (though I have a hard time searching with two little children sitting on my lap, completely taken out of their rhythm last 4 days of christmas:P)

I will search a bit. Bigbeargames sent me a zip file back then with a lot of his stuff, including items that he also submitted here later (like the weapon mega pack etc). I will send you that zip file, would that help?

The wolves are a new addition! Commisioned them and Bencreating that another awesome job, as always. But he just sent me them like four days ago or something, and he will submit them here somewhere coming days I assume.
A small LPC christmas present (and we work on more stuff atm, including a battle boar (which is absolutely stunning, you'll be amazed) and a boarman...:D)

I will search the zip!

Saturday, December 26, 2020 - 06:42

Awesome job bluecarrot!!

If I understand correctly, what I can do is load the csv into memory. Then, for each selected image I can determine the author and the url. With the set created from this (I can also filter uniques), when someone clicks the credits button I can create a text file with the right attribution for the created sheet. That will cover all necessities for the correct crediting.

I think we can also add the license explanation etc to the same directory in the generator. And I can remove the "work" I did up to now to get the credits-url as part of the generator html. I will do the efforts to make this work when the CSV is ready to be used.

Considering the files you mention like arms/1.png; these are all recolors of the lpc plate armour. A while back bigbeargames shared those with me. He created them from the lpc plate armour sheets by running some scripts. As they are made programmatically, I am not sure how to credit them. Maybe just by referring to the original submissions (indeed Wulax's; btw that submission is one of the best imo for LPC:D. Also in his submission he specifically waives that DRM clause, is that something we should also take into some form into the CSV file)?

I hope you both understand that I didn't want to say that the crediting is not needed or useless. I fully agree it is a necessity legally, but also a much deserved appreciation towards the creators. I only wanted to take the idea potentially a bit further in order to not only have correct credits in place, but also in such a way that it could tempt readers to visit OGA, or even contribute to the LPC sets.

Looking at the work you described bluecarrot I understand better how we can use it, and it is a great effort that will simplify the crediting challenge tremendously. The only thing we need to make sure of is that when a file is moved or added to the generator, the csv needs to be updated. So I will add that as well to the project's readme once the time has come.

Pages